Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code scanning alert no. 1: Use of insecure SSL/TLS version #1826

Merged
merged 1 commit into from
Jan 17, 2025

Conversation

pipiche38
Copy link
Collaborator

Fixes https://github.com/zigbeefordomoticz/Domoticz-Zigbee/security/code-scanning/1

To fix the problem, we need to ensure that the ssl.SSLContext is configured to use a secure protocol, specifically TLS 1.2 or above. This can be done by setting the minimum_version attribute of the SSLContext to ssl.TLSVersion.TLSv1_2. This change should be made when the SSLContext is created to ensure that only secure protocols are used.

Suggested fixes powered by Copilot Autofix. Review carefully before merging.

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@pipiche38 pipiche38 changed the base branch from stable7 to rc-stable7-019 January 14, 2025 17:14
@pipiche38 pipiche38 marked this pull request as ready for review January 17, 2025 10:46
@pipiche38 pipiche38 merged commit 43cf3dc into rc-stable7-019 Jan 17, 2025
5 checks passed
@pipiche38 pipiche38 deleted the fix-use-insecure-ssl-tls-version branch January 26, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant